-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
degroup() for nested models #533
Conversation
@jmgirard you may "review" this PR, too, if you like. |
@jmgirard do you think we can merge this? You may look just at the changes in |
The code and test looks good. The documentation should mention somewhere that a hybrid model that includes both nested and crossed levels is currently unsupported. I'm also still wondering if it is better to use names like {"math_between_school", "math_between_classroom", and "math_within"} or {"math_L3", "math_L2", and "math_L1"}. Perhaps the |
Using names instead of L3, L2 etc. follows the same scheme as for cross classified designs. Maybe we can ind ed extend the |
Fixes #530