Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

degroup() for nested models #533

Merged
merged 13 commits into from
Aug 27, 2024
Merged

degroup() for nested models #533

merged 13 commits into from
Aug 27, 2024

Conversation

strengejacke
Copy link
Member

Fixes #530

@strengejacke strengejacke marked this pull request as ready for review August 18, 2024 22:39
@strengejacke
Copy link
Member Author

@jmgirard you may "review" this PR, too, if you like.

@strengejacke
Copy link
Member Author

@jmgirard do you think we can merge this? You may look just at the changes in demean.R and the related test file in this PR for a quick review... Then this PR could probably included in the next release.

@jmgirard
Copy link

@jmgirard do you think we can merge this? You may look just at the changes in demean.R and the related test file in this PR for a quick review... Then this PR could probably included in the next release.

The code and test looks good. The documentation should mention somewhere that a hybrid model that includes both nested and crossed levels is currently unsupported. I'm also still wondering if it is better to use names like {"math_between_school", "math_between_classroom", and "math_within"} or {"math_L3", "math_L2", and "math_L1"}. Perhaps the suffix_* arguments could be customized for nested models?

@strengejacke
Copy link
Member Author

strengejacke commented Aug 26, 2024

Using names instead of L3, L2 etc. follows the same scheme as for cross classified designs. Maybe we can ind ed extend the suffix argument to allow different naming schemes. But I would keep that for a later update.

@strengejacke strengejacke merged commit bc52b99 into main Aug 27, 2024
22 checks passed
@strengejacke strengejacke deleted the strengejacke/issue530 branch August 27, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

degroup() for nested models
2 participants