Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix R CMD check errors on vignette for macOS-R 4.3 #528

Merged
merged 9 commits into from
Jul 20, 2024

Conversation

etiennebacher
Copy link
Member

@etiennebacher etiennebacher commented Jul 20, 2024

First of all I realized that none of the workflows ran on macOS with R 4.3, which is precisely where this failure occurs. So I temporarily deactivate all other workflows and try to reproduce on this config.


Edit: Everything worked fine on macOS with R 4.3. I now remove the htmltools dependency and use raw HTML in the vignettes.

Close #527

@etiennebacher etiennebacher marked this pull request as ready for review July 20, 2024 14:29
Copy link
Member

@IndrajeetPatil IndrajeetPatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

NEWS.md Outdated Show resolved Hide resolved
@etiennebacher etiennebacher merged commit 539bba2 into main Jul 20, 2024
@etiennebacher etiennebacher deleted the fix-vignette-error branch July 20, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix build failures on macOS 4.3
2 participants