Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexpected missing values in data_tabulate() #518

Merged
merged 6 commits into from
Jun 23, 2024
Merged

Unexpected missing values in data_tabulate() #518

merged 6 commits into from
Jun 23, 2024

Conversation

strengejacke
Copy link
Member

Fixes #514

@strengejacke
Copy link
Member Author

strengejacke commented Jun 22, 2024 •
edited
Loading

Docs need to be changed too

IndrajeetPatil
IndrajeetPatil approved these changes Jun 23, 2024
View reviewed changes
Copy link
Member

@IndrajeetPatil IndrajeetPatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM. Few minor comments.

NEWS.md Outdated Show resolved Hide resolved
R/data_summary.R Show resolved Hide resolved
R/data_xtabulate.R Show resolved Hide resolved
strengejacke and others added 2 commits June 23, 2024 11:17
@strengejacke @IndrajeetPatil
Update NEWS.md
51c8b5f 
Co-authored-by: Indrajeet Patil <[email protected]>
@strengejacke
add comment
17f8736
@codecov Codecov
Copy link

codecov bot commented Jun 23, 2024

Codecov Report

Attention: Patch coverage is 96.42857% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.00%. Comparing base (480634e) to head (17f8736).
Report is 4 commits behind head on main.

Files Patch % Lines
R/data_summary.R 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #518      +/-   ##
==========================================
+ Coverage   89.97%   90.00%   +0.02%     
==========================================
  Files          75       75              
  Lines        5924     5941      +17     
==========================================
+ Hits         5330     5347      +17     
  Misses        594      594

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@strengejacke strengejacke merged commit ebe48b4 into main Jun 23, 2024
25 of 30 checks passed
@strengejacke strengejacke deleted the strengejacke/issue514 branch June 23, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IndrajeetPatil IndrajeetPatil IndrajeetPatil approved these changes

@etiennebacher etiennebacher Awaiting requested review from etiennebacher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected missing values in data_tabulate()
2 participants
@strengejacke @IndrajeetPatil