Release 0.9.1

[etiennebacher]

Submitted to CRAN.

I ran revdepcheck locally, no problem.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fd70667) 89.40% compared to head (571051b) 89.40%.

❗ Current head 571051b differs from pull request most recent head bae0ae6. Consider uploading reports for the commit bae0ae6 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #475   +/-   ##
=======================================
  Coverage   89.40%   89.40%           
=======================================
  Files          72       72           
  Lines        5419     5419           
=======================================
  Hits         4845     4845           
  Misses        574      574           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[etiennebacher]

Failed submission due to failure in vignette rendering on Windows: https://win-builder.r-project.org/incoming_pretest/datawizard_0.9.1_20231220_094014/Debian/00check.log

Thanks, we see:

• checking re-building of vignette outputs ... [0m/30m] ERROR

Please reduce the vignette build timings by using

• small toy data only
• few iterations
• or by providing precomputed results for the most lengthy parts.
  Otherwise we cannot afford checking the vignette regularly on CRAN.

Please keep the overall package check time < 10 min.

Best,

[strengejacke]

Did we have any changes in the vignettes?

[strengejacke]

Is this a false-positive? Running all tests takes ~40 seconds, knitting vignettes ~10 sec. per vignette.

[strengejacke]

This is what the local check returns, I think the issue is a different one here:

Duration: 1m 17.9s

❯ checking re-building of vignette outputs ... ERROR
  Error(s) in re-building vignettes:
    ...
  --- re-building 'selection_syntax.Rmd' using rmarkdown
  Error: processing vignette 'selection_syntax.Rmd' failed with diagnostics:
  there is no package called 'rmarkdown'
  --- failed re-building 'selection_syntax.Rmd'
  
  --- re-building 'standardize_data.Rmd' using rmarkdown
  Error: processing vignette 'standardize_data.Rmd' failed with diagnostics:
  there is no package called 'rmarkdown'
  --- failed re-building 'standardize_data.Rmd'
  
  --- re-building 'tidyverse_translation.Rmd' using rmarkdown
  Error: processing vignette 'tidyverse_translation.Rmd' failed with diagnostics:
  there is no package called 'rmarkdown'
  --- failed re-building 'tidyverse_translation.Rmd'
  
  SUMMARY: processing the following files failed:
    'selection_syntax.Rmd' 'standardize_data.Rmd'
    'tidyverse_translation.Rmd'
  
  Error: Vignette re-building failed.
  Execution halted

1 error ✖ | 0 warnings ✔ | 0 notes ✔
Error: R CMD check found ERRORs
Execution halted

Exited with status 1.

Looks like a false-positive, I would send this report to the CRAN team and ask if they can verify that it's no issue with datawizard. Total check time was far below 10 minutes.

[etiennebacher]

Yes I also think it's a false positive. I'm waiting for rhub results before telling CRAN

[etiennebacher]

The problem is that we download a dataset from github in the "standardize data" vignette, and this can time out in case of slow internet connection.

In any case we should handle the case when there's no internet

[etiennebacher]

I can't take a look before tonight

[strengejacke]

Ok. I added a check for internet connection to the vignette, you can review my changes tonight, maybe that solves the problem.

[etiennebacher]

Resubmitted

[etiennebacher]

Accepted, thanks for the quick fix @strengejacke