-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rescale() can expand ranges #467
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #467 +/- ##
==========================================
+ Coverage 89.03% 89.09% +0.05%
==========================================
Files 72 72
Lines 5383 5409 +26
==========================================
+ Hits 4793 4819 +26
Misses 590 590 ☔ View full report in Codecov by Sentry. |
@bwiernik @etiennebacher we could add an alias |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, minor things
Hard to say, I don't have a use case for this function in mind, I guess you have one?
wouldn't this create a conflict with |
It seems that expected behaviour in this case would be to add add to min/max (I have changed this here already), see https://bsky.app/profile/tjmahr.com/post/3ke3nc3hix32u
True. So no alias. |
I'm not on bluesky, can you share a screenshot? (sorry I edited your post instead of writing a comment) |
I'm fine on Mastodon for now, thanks ;) |
Social networks have become less important anyway, or have pretty much fallen asleep since Musk took over Twitter. |
I don't know, I just can't understand the hype for bluesky, I don't see any reason why it will end up differently than twitter, but anyway that's not the topic 😄 |
Personally I like Threads a lot among the various options |
Similar to
scales::expand_range()
,rescale()
can now also expand ranges:Not sure, though, if
add
should add (subtract) the value to each end of the range? I.e. new range =c(min - add, max + add)
? Then the range would expand by2*add
.