Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use withr in tests of data_write() #464

Merged
merged 2 commits into from
Oct 8, 2023
Merged

Conversation

etiennebacher
Copy link
Member

Close #462

@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

Merging #464 (722ead3) into main (6c3bcf5) will not change coverage.
The diff coverage is n/a.

❗ Current head 722ead3 differs from pull request most recent head be7957b. Consider uploading reports for the commit be7957b to get more accurate results

@@           Coverage Diff           @@
##             main     #464   +/-   ##
=======================================
  Coverage   89.03%   89.03%           
=======================================
  Files          72       72           
  Lines        5383     5383           
=======================================
  Hits         4793     4793           
  Misses        590      590           

Copy link
Member

@IndrajeetPatil IndrajeetPatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thanks.

Feel free to run {styler} once and then merge.

@etiennebacher etiennebacher merged commit b2d3b1b into main Oct 8, 2023
14 checks passed
@etiennebacher etiennebacher deleted the test-data-write-withr branch October 8, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use {withr} for managing side effects in tests
2 participants