Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data_write() for partially labelled characters #459

Merged
merged 5 commits into from
Sep 14, 2023
Merged

Conversation

strengejacke
Copy link
Member

@etiennebacher We should merge this fix before submiting datawizard.

@etiennebacher etiennebacher changed the title fix data_write for partially labelled characters Fix data_write() for partially labelled characters Sep 14, 2023
tests/testthat/test-data_write.R Show resolved Hide resolved
tests/testthat/test-data_write.R Outdated Show resolved Hide resolved
@strengejacke
Copy link
Member Author

Working with real-life data is the best stress-test ;-)

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #459 (c8adf79) into main (2989935) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head c8adf79 differs from pull request most recent head 9dc9bd9. Consider uploading reports for the commit 9dc9bd9 to get more accurate results

@@           Coverage Diff           @@
##             main     #459   +/-   ##
=======================================
  Coverage   89.02%   89.02%           
=======================================
  Files          72       72           
  Lines        5375     5377    +2     
=======================================
+ Hits         4785     4787    +2     
  Misses        590      590           
Files Changed Coverage Δ
R/data_write.R 88.03% <100.00%> (+0.20%) ⬆️

@strengejacke strengejacke merged commit 6e93950 into main Sep 14, 2023
25 of 26 checks passed
@strengejacke strengejacke deleted the fix_data_write branch September 14, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants