Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename change_code() to recode_values() #235

Merged
merged 2 commits into from
Aug 25, 2022
Merged

Rename change_code() to recode_values() #235

merged 2 commits into from
Aug 25, 2022

Conversation

IndrajeetPatil
Copy link
Member

@IndrajeetPatil IndrajeetPatil commented Aug 24, 2022

@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2022

Codecov Report

Merging #235 (0108117) into main (6adeff4) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #235      +/-   ##
==========================================
+ Coverage   84.57%   84.58%   +0.01%     
==========================================
  Files          53       53              
  Lines        3429     3432       +3     
==========================================
+ Hits         2900     2903       +3     
  Misses        529      529              
Impacted Files Coverage Δ
R/data_rename.R 93.93% <ø> (ø)
R/text_format.R 100.00% <ø> (ø)
R/adjust.R 69.56% <100.00%> (ø)
R/categorize.R 91.93% <100.00%> (+0.06%) ⬆️
R/center.R 98.50% <100.00%> (ø)
R/convert_na_to.R 89.18% <100.00%> (ø)
R/convert_to_na.R 86.66% <100.00%> (ø)
R/data_arrange.R 100.00% <100.00%> (ø)
R/data_extract.R 85.71% <100.00%> (ø)
R/data_group.R 88.00% <100.00%> (ø)
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@strengejacke
Copy link
Member

Do we still have the alias change_code() in case we need it for the paper submission? (else, we probably still could keep the alias for one release cycle, including a deprecation warning)

@IndrajeetPatil
Copy link
Member Author

Yes

export(change_code)

@IndrajeetPatil IndrajeetPatil merged commit a9668f6 into main Aug 25, 2022
@IndrajeetPatil IndrajeetPatil deleted the 233_rename branch August 25, 2022 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-rename change_code()?
3 participants