Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests cleanup #282

Merged
merged 2 commits into from
Mar 24, 2023
Merged

Tests cleanup #282

merged 2 commits into from
Mar 24, 2023

Conversation

etiennebacher
Copy link
Member

@etiennebacher etiennebacher commented Mar 24, 2023

  1. Silence messages, cf Suppress irrelevant warnings and messages in tests easystats#338: there are duplicated messages "For i = 2 j = 1 A cell entry of 0 was replaced with correct = 0.5. Check your data!" in test-correlation.R. This is not expected and is reported in method = "auto" not working for ordinal variables #260

  2. Use skip_if_not_or_load_if_installed() inside test_that() calls, cf Simplify conditional expressions in tests: Part-2 easystats#350

I also see a bunch of warnings but they are already reported in the R CMD check strict so it shouldn't be fixed in this PR.

Copy link
Member

@IndrajeetPatil IndrajeetPatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @etiennebacher!

@IndrajeetPatil IndrajeetPatil merged commit c413bbe into main Mar 24, 2023
@IndrajeetPatil IndrajeetPatil deleted the test-cleanup branch March 24, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants