Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
  • Loading branch information
mattansb committed Jan 26, 2021
1 parent 9340871 commit 554ca85
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions R/rope_range.R
Original file line number Diff line number Diff line change
Expand Up @@ -175,13 +175,13 @@ rope_range.mlm <- function(x, ...) {
{
# Linear Models
if (information$is_linear) {
warning("Note that the default rope range for binomial models might change in future versions (see https://github.com/easystats/bayestestR/issues/364).",
"Please set it explicitly to preserve current results.")
0.1 * stats::sd(response, na.rm = TRUE)

# Logistic Regression Models
} else if (information$is_binomial) {
warning("Note that the default rope range for binomial models might change in future versions (see https://github.com/easystats/bayestestR/issues/364). Please set it explicitly (`range = 0.1 * pi / sqrt(3)`) to preserve current results.")
0.1 * pi / sqrt(3)

# Count Models
} else if (information$is_count) {
sig <- stats::sigma(x)
Expand Down

4 comments on commit 554ca85

@strengejacke
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So why is the warning appearing for linear models only, when it refers to binomial models?

@mattansb
Copy link
Member Author

@mattansb mattansb commented on 554ca85 Jan 27, 2021 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattansb
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@DominiqueMakowski
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I didn't double checked... too hasty moves

Please sign in to comment.