-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove code supporting obsolete versions from IntelBase
family of easyblocks + remove unused custom easyblock for IPP
#3533
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lots of code to review, but lgtm i think
IntelBase
family of easyblocks + remove unused custom easyblock for IPP
Test report by @lexming Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
Test report by @lexming Overview of tested easyconfigs (in order)
Build succeeded for 4 out of 4 (4 easyconfigs in total) |
Test report by @lexming Overview of tested easyconfigs (in order)
Build succeeded for 4 out of 4 (4 easyconfigs in total) |
Should i just ignore the failures? I'm not what's happening, figured i'd let you finish testing before i started running through a bunch of them. |
Failures were due to issues on my side. Like forgetting to accept the EULA. All tests I've done are reported here and they are positive. But I've not tested anything else than iccifort, impi and imkl so far. |
Hm, this confuses me. I can't just --include-easyblocks-from-pr 3533 because it complains that
My only guess is that it's due to it not seeing the
Not this PR's fault i think, but it's a bit frustrating to test. I'll have to snag the intelbase manually |
@Micket |
No it's being removed there as well
There is for me. In frustration, I even attempted to delete the local easyblocks i had to force it to only pick them up from the --include-easyblocks-from-pr, but then I simply hit problems like
(here I tested deleting my local tbb.py) |
Test report by @branfosj Overview of tested easyconfigs (in order)
Build succeeded for 5 out of 5 (6 easyconfigs in total) |
Test report by @branfosj Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
Test report by @branfosj Overview of tested easyconfigs (in order)
Build succeeded for 5 out of 5 (5 easyconfigs in total) |
Test report by @branfosj Overview of tested easyconfigs (in order)
Build succeeded for 4 out of 4 (4 easyconfigs in total) |
Test report by @branfosj Overview of tested easyconfigs (in order)
Build succeeded for 12 out of 12 (1 easyconfigs in total) |
Test report by @branfosj Overview of tested easyconfigs (in order)
Build succeeded for 8 out of 8 (8 easyconfigs in total) |
Test report by @branfosj Overview of tested easyconfigs (in order)
Build succeeded for 1 out of 1 (1 easyconfigs in total) |
Test report by @branfosj Overview of tested easyconfigs (in order)
Build succeeded for 152 out of 164 (82 easyconfigs in total) |
Test report by @branfosj Overview of tested easyconfigs (in order)
Build succeeded for 4 out of 4 (4 easyconfigs in total) |
Remove code from
IntelBase
easyblock and its derivatives that is specific to obsolete versions or features:m32
supportusetmppath
supportList of affected easyblocks: