Skip to content

Commit

Permalink
Merge pull request #3539 from boegel/pythonpackage_fix_builcmd_python…
Browse files Browse the repository at this point in the history
…_template

inject custom '`%(python)s`' template value before getting value of '`buildcmd`' custom easyconfig parameter in `PythonPackage` easyblock
  • Loading branch information
lexming authored Dec 19, 2024
2 parents 47fe3fa + 51ce299 commit 90c14fe
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions easybuild/easyblocks/generic/pythonpackage.py
Original file line number Diff line number Diff line change
Expand Up @@ -818,7 +818,11 @@ def configure_step(self):

def build_step(self):
"""Build Python package using setup.py"""
build_cmd = self.cfg.get_ref('buildcmd')

# inject extra '%(python)s' template value before getting value of 'buildcmd' custom easyconfig parameter
self.cfg.template_values['python'] = self.python_cmd
build_cmd = self.cfg['buildcmd']

if self.use_setup_py:

if get_software_root('CMake'):
Expand All @@ -829,10 +833,9 @@ def build_step(self):

if not build_cmd:
build_cmd = 'build' # Default value for setup.py
build_cmd = '%(python)s setup.py ' + build_cmd
build_cmd = f"{self.python_cmd} setup.py {build_cmd}"

if build_cmd:
build_cmd = build_cmd % {'python': self.python_cmd}
cmd = ' '.join([self.cfg['prebuildopts'], build_cmd, self.cfg['buildopts']])
res = run_shell_cmd(cmd)

Expand Down

0 comments on commit 90c14fe

Please sign in to comment.