Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete extra constants #370

Merged
merged 1 commit into from
Nov 4, 2024
+3 −7
Merged

Delete extra constants #370

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions icechunk/src/storage/s3.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,9 @@ use crate::{
Storage, StorageError,
};

use super::{ListInfo, StorageResult};
use super::{
ListInfo, StorageResult, CHUNK_PREFIX, MANIFEST_PREFIX, REF_PREFIX, SNAPSHOT_PREFIX,
};

#[derive(Debug)]
pub struct S3Storage {
Expand Down Expand Up @@ -119,12 +121,6 @@ pub async fn mk_client(config: Option<&S3Config>) -> Client {
Client::from_conf(config)
}

const SNAPSHOT_PREFIX: &str = "snapshots/";
const MANIFEST_PREFIX: &str = "manifests/";
// const ATTRIBUTES_PREFIX: &str = "attributes/";
const CHUNK_PREFIX: &str = "chunks/";
const REF_PREFIX: &str = "refs";

impl S3Storage {
pub async fn new_s3_store(
bucket_name: impl Into<String>,
Expand Down
Loading