Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pickling of stores #349

Merged
merged 3 commits into from
Oct 30, 2024
Merged

Fix pickling of stores #349

merged 3 commits into from
Oct 30, 2024

Conversation

dcherian
Copy link
Contributor

Closes #348

not sure what to fix yet.

@mpiannucci
Copy link
Contributor

For now we are just going to keep the error for memory pickles, and make sure the filesystem pickles are tested correctly

@mpiannucci mpiannucci requested a review from paraseba October 29, 2024 19:56
@paraseba paraseba merged commit 5aa9abe into main Oct 30, 2024
2 checks passed
@paraseba paraseba deleted the pickle-tests branch October 30, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pickling of icechunk stores is broken
3 participants