All python repo methods are sync now #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are also versions with the same name starting with `async` that are async. Example: `commit` (sync) and `async_commit` (async). I don't like this, it's not a good API, but it will have to do for now. We'll refactor soon.
mpiannucci
reviewed
Oct 14, 2024
mpiannucci
approved these changes
Oct 14, 2024
paraseba
force-pushed
the
seba/sync-api
branch
from
6f928a0 to
2b297e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are also versions with the same name starting with
asyncthat are async. Example:commit(sync) andasync_commit(async).I don't like this, it's not a good API, but it will have to do for now. We'll refactor soon.
Reviewers:
Optional (@rabernat )