Skip to content

Commit

Permalink
Revert "Makefile: Add GCC config options to --enable-checking=all"
Browse files Browse the repository at this point in the history
with `--enable-checking=all`, ed86506 surely inhibits ICE such as:
```
/tmp/esp-quick-toolchain/repo/newlib/newlib/libc/stdlib/__exp10.c:19:20: internal compiler error: RTL check: expected code 'const_int', have 'symbol_ref' in xtensa_emit_move_sequence, at config/xtensa/xtensa.c:1079
```

by the way, however, `--enable-checking=all` reveals another issue; building stops by ICE in `.stage.LINUX.libstdcpp`:
```
In file included from /tmp/esp-quick-toolchain/arena.x86_64/gcc-gnu/xtensa-lx106-elf/libstdc++-v3/include/bits/hashtable.h:35,
                 from /tmp/esp-quick-toolchain/arena.x86_64/gcc-gnu/xtensa-lx106-elf/libstdc++-v3/include/unordered_map:46,
                 from /tmp/esp-quick-toolchain/repo/gcc-gnu/libstdc++-v3/include/precompiled/stdc++.h:117:
/tmp/esp-quick-toolchain/arena.x86_64/gcc-gnu/xtensa-lx106-elf/libstdc++-v3/include/bits/hashtable_policy.h:787:23: internal compiler error: in discriminator_for_local$
      |  __throw_out_of_range(__EXCSTR(__N("_Map_base::at")));
      |                       ^~~~~~~~
0x5fe038 discriminator_for_local_entity
        /tmp/esp-quick-toolchain/repo/gcc-gnu/gcc/cp/mangle.c:1910
(snip)
```
```
static int
discriminator_for_local_entity (tree entity)
{
  if (!DECL_LANG_SPECIFIC (entity))
    {
      /* Some decls, like __FUNCTION__, don't need a discriminator.  */
      gcc_checking_assert (DECL_ARTIFICIAL (entity));
      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      return 0;
    }
  else if (tree disc = DECL_DISCRIMINATOR (entity))
    return TREE_INT_CST_LOW (disc);
  else
    /* The first entity with a particular name doesn't get
       DECL_DISCRIMINATOR set up.  */
    return 0;
}
```
(https://github.com/gcc-mirror/gcc/blob/releases/gcc-10.3.0/gcc/cp/mangle.c#L1910)

but the abovementioned issue seems not to be related to this PR and should be posted as detached issue/PR, i guess.
then, this reverts commit 0b97526.
  • Loading branch information
jjsuwa-sys3175 committed Sep 9, 2021
1 parent 0b97526 commit 7a464ef
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,6 @@ configure += --enable-languages=c,c++
configure += --enable-lto
configure += --enable-static=yes
configure += --disable-libstdcxx-verbose
configure += --enable-checking=all

# Newlib configuration common
CONFIGURENEWLIBCOM = --with-newlib
Expand Down

0 comments on commit 7a464ef

Please sign in to comment.