Skip to content

Commit

Permalink
Build Exiv2 without inih library (google#9437)
Browse files Browse the repository at this point in the history
This fixes the build failure in Exiv2.

We recently added [inih](https://github.com/benhoyt/inih) as a
dependency to Exiv2, but we need a newer version of inih that includes
the C++ bindings. OSS-Fuzz is still using a docker image based on Ubuntu
20.04 which doesn't include a sufficiently up-to-date version of the
`libinih-dev` package. So I've added a build flag to Exiv2 in
Exiv2/exiv2#2465 which enables us to build
without the inih dependency. The fuzz target doesn't need inih, so it
shouldn't make any difference to the fuzzing results.
  • Loading branch information
kevinbackhouse authored and eamonnmcmanus committed Mar 15, 2023
1 parent 54c174e commit 5ac7910
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion projects/exiv2/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ CXXFLAGS="${CXXFLAGS} -fno-sanitize=float-divide-by-zero"
# Build Exiv2
mkdir -p build
cd build
cmake -DEXIV2_ENABLE_PNG=ON -DEXIV2_ENABLE_WEBREADY=ON -DEXIV2_ENABLE_CURL=OFF -DEXIV2_ENABLE_BMFF=ON -DEXIV2_TEAM_WARNINGS_AS_ERRORS=ON -DBUILD_SHARED_LIBS=OFF -DCMAKE_CXX_COMPILER="${CXX}" -DCMAKE_CXX_FLAGS="${CXXFLAGS}" -DEXIV2_BUILD_FUZZ_TESTS=ON -DEXIV2_TEAM_OSS_FUZZ=ON -DLIB_FUZZING_ENGINE="${LIB_FUZZING_ENGINE}" ..
cmake -DEXIV2_ENABLE_PNG=ON -DEXIV2_ENABLE_WEBREADY=ON -DEXIV2_ENABLE_CURL=OFF -DEXIV2_ENABLE_BMFF=ON -DEXIV2_TEAM_WARNINGS_AS_ERRORS=ON -DBUILD_SHARED_LIBS=OFF -DCMAKE_CXX_COMPILER="${CXX}" -DCMAKE_CXX_FLAGS="${CXXFLAGS}" -DEXIV2_BUILD_FUZZ_TESTS=ON -DEXIV2_TEAM_OSS_FUZZ=ON -DLIB_FUZZING_ENGINE="${LIB_FUZZING_ENGINE}" -DEXIV2_ENABLE_INIH=OFF ..
make -j $(nproc)

# Copy binary and dictionary to $OUT
Expand Down

0 comments on commit 5ac7910

Please sign in to comment.