patch(vest): Set history root when exiting the root node #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ealush
force-pushed
the
2024-08-11-put-history-in-the-past
branch
from
3541ada to
519bb49
Compare
ealush
force-pushed
the
2024-08-11-put-history-in-the-past
branch
from
519bb49 to
f992fa9
Compare
ealush
force-pushed
the
2024-08-11-put-history-in-the-past
branch
from
f992fa9 to
3841ee9
Compare
ealush
force-pushed
the
2024-08-11-put-history-in-the-past
branch
from
3841ee9 to
ec3f882
Compare
ealush
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous version of this code, Vest would set the history root node right when entering the topmost root, making the concept of "history" root node meaningless. This correctly sets the history root node only when exiting the topmost node.