Ensure deps are deduped to keep lockfile smaller #1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ealush
approved these changes
Jul 31, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Aug 7, 2024
…me]: (1.4.1), [vast]: (1.0.40), [n4s]: (5.0.26), [vest]: (5.4.1), [anyone]: (1.0.30) 0462bc0 patch(vest): Improve omitWhen performance using a lazy draft object (ealush) 54f0618 Yarn Dedupe (Evyatar) 1496987 Add eslint vitest plugin (Evyatar) 3e976a5 vx: run prettier on the generated vitest file (Evyatar) fe1c5cf Replace jest with vitest (ealush) 1b50ad6 Ensure deps are deduped to keep lockfile smaller (#1150) (Amit Dahan)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
yarn dedupe --checkin CI means we can never merge a PR that has the lockfile in a state where it can be deduped further by runningyarn dedupe.This also means Dependabot PRs can sometimes be red due to this, and will require manually running
yarn dedupeand commit pushing the changes.If Dependabot supported automatically running dedupe, or running custom post-update actions like Renovate - I would have configured it so this wouldn't add friction there, but I can't atm.
I suggest considering Renovate regardless.