Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Prettier in CI #1149

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Run Prettier in CI #1149

merged 1 commit into from
Aug 1, 2024

Conversation

amitdahan
Copy link
Contributor

@amitdahan amitdahan commented Jul 31, 2024

Q A
Bug fix?
New feature?
Breaking change?
Deprecations?
Documentation?
Tests added?
Types added?
Related issues

Seems Prettier is configured, but not enforced in CI.

This means that when contributors "touch" a certain file that wasn't formatted before - it will increase their change's scope by also adding unrelated formatting changes.

This PR means this won't happen again.

Copy link

vercel bot commented Jul 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vest ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2024 1:51pm
vest-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2024 1:51pm

@ealush ealush merged commit 6f7fdef into ealush:latest Aug 1, 2024
5 of 6 checks passed
ealush pushed a commit that referenced this pull request Aug 1, 2024
* Prettier in CI (#1149)

* yarn dedupe

* simplify enforce test

* simplify isolate test

* simplify key test

* remove unnecessary things
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants