Adding some basic data types to simplify photolysis rate calculations #261
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a column-independent struct called
PhotoTableData
that stores all the data used to interpolate photolysis rates, and a column-specific struct calledPhotoTableWorkArrays
that contains views that function as work arrays. These two types encapsulate array data that once lived in Fortran module variables. I find it too hard to work with functions with 87 arguments, so this is how I've been dealing with them. :-)No logic is changed, apart from the order of allocation of views. I hope this will allow me to simplify the photolysis code in our EAMxx aerosol microphysics process.