Update Now API docs change log #1321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dkluever22
commented
Sep 18, 2023
dkluever22
commented
- announces newly added paths for product PATCH
- announces newly added attributes
- adds links to data types
* announce newly added paths for product PATCH * announce newly added attributes * adding links to data types
bolsu
approved these changes
Sep 19, 2023
ywolpers
reviewed
Sep 19, 2023
|
|
||
| #### <i class="fas fa-pencil-alt"></i> Update | ||
|
|
||
| * Added the following attribute paths being updatable via [`PATCH`/products/{productId}](https://developer.epages.com/apps/api-reference/patch-shopid-products-productid.html): |
There was a problem hiding this comment.
Suggested change
| * Added the following attribute paths being updatable via [`PATCH`/products/{productId}](https://developer.epages.com/apps/api-reference/patch-shopid-products-productid.html): | |
| * The following attribute paths can now be updated via [`PATCH`/products/{productId}](https://developer.epages.com/apps/api-reference/patch-shopid-products-productid.html): |
As per
@AliceStatler Do you agree?
There was a problem hiding this comment.
@ywolpers It seems that we always start with "Added" for the Update section. We can discuss with Daria whether this is necessary or even the default. However, as she is not here, I would like to stick with her previous solution.
There was a problem hiding this comment.
@AliceStatler Hm yeah, if the action is that something is "Added", yes, but we also have some "Update" infos starting with "Renamed" or "Updated" - or like in the example screenshot "The attribute path...". But ok, let's keep it as it is for now. People will probably understand what is meant here either way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.