Configurable max_msg_size #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaoxichen
force-pushed
the
max_msg_size
branch
2 times, most recently
from
b8858dd to
6d1d313
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #79 +/- ##
==========================================
+ Coverage 71.36% 74.20% +2.84%
==========================================
Files 21 20 -1
Lines 887 853 -34
Branches 103 98 -5
==========================================
Hits 633 633
+ Misses 189 155 -34
Partials 65 65 ☔ View full report in Codecov by Sentry. |
xiaoxichen
force-pushed
the
max_msg_size
branch
from
6d1d313 to
7d2a646
Compare
Upper layer can pass in
params.max_message_size_
to specified the max message size the GRPC server will accept.
UT with params.max_message_size_ set to 65MB and SEND_DATA up to 4MB.
SEND_DATA with 64MB is not stable as raft hb timeout can be easily
triggered.
Signed-off-by: Xiaoxi Chen <[email protected]>
xiaoxichen
force-pushed
the
max_msg_size
branch
from
7d2a646 to
cacd32a
Compare
hkadayam
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upper layer can pass in
params.max_message_size_
to specified the max message size the GRPC server will accept.
UT with params.max_message_size_ set to 65MB and SEND_DATA up to 64MB which is our target max_blob_size.