Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sisl 12.x #78

Merged
merged 4 commits into from
Mar 25, 2024
Merged

Use sisl 12.x #78

merged 4 commits into from
Mar 25, 2024

Conversation

hkadayam
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Mar 23, 2024

Codecov Report

Attention: Patch coverage is 52.27273% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 73.83%. Comparing base (f32857f) to head (ed28c65).

Files Patch % Lines
src/proto/proto_mesg_factory.cpp 52.27% 19 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #78      +/-   ##
==========================================
- Coverage   75.27%   73.83%   -1.45%     
==========================================
  Files          20       20              
  Lines         821      856      +35     
  Branches       94       98       +4     
==========================================
+ Hits          618      632      +14     
- Misses        141      159      +18     
- Partials       62       65       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hkadayam hkadayam requested a review from szmyd March 24, 2024 20:21
Copy link
Contributor

@xiaoxichen xiaoxichen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm in general

src/proto/proto_mesg_factory.cpp Outdated Show resolved Hide resolved
src/proto/proto_mesg_factory.cpp Show resolved Hide resolved
szmyd
szmyd previously approved these changes Mar 25, 2024
src/proto/proto_mesg_factory.cpp Outdated Show resolved Hide resolved
xiaoxichen
xiaoxichen previously approved these changes Mar 25, 2024
@hkadayam hkadayam dismissed stale reviews from xiaoxichen and szmyd via df9a4b2 March 25, 2024 16:31
@hkadayam hkadayam merged commit 009f47c into eBay:main Mar 25, 2024
12 checks passed
@hkadayam hkadayam deleted the use_sisl12 branch March 25, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants