Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow the client of nuraft_mesg to provide a raft event handler #75

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Allow the client of nuraft_mesg to provide a raft event handler #75

merged 2 commits into from
Mar 6, 2024

Conversation

hkadayam
Copy link
Contributor

@hkadayam hkadayam commented Mar 6, 2024

One use case for this client event handling is for pre-append callback that Raft provides and allow the client of nuraft_mesg to deny the append

@hkadayam hkadayam requested review from szmyd and raakella1 March 6, 2024 03:05
szmyd
szmyd reviewed Mar 6, 2024
View reviewed changes
src/lib/manager_impl.cpp Outdated Show resolved Hide resolved
szmyd
szmyd reviewed Mar 6, 2024
View reviewed changes
src/lib/manager_impl.cpp Outdated Show resolved Hide resolved
szmyd
szmyd reviewed Mar 6, 2024
View reviewed changes
src/lib/manager_impl.cpp Outdated Show resolved Hide resolved
szmyd
szmyd previously approved these changes Mar 6, 2024
View reviewed changes
Copy link
Collaborator

@szmyd szmyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes suggested.

@hkadayam hkadayam requested a review from szmyd March 6, 2024 17:15
@hkadayam hkadayam merged commit b9566ad into eBay:main Mar 6, 2024
12 checks passed
@hkadayam hkadayam deleted the pass_event_handler branch March 6, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raakella1 raakella1 Awaiting requested review from raakella1

@szmyd szmyd Awaiting requested review from szmyd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hkadayam @szmyd