Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove confusing indirection. #49

Merged
merged 1 commit into from
Nov 11, 2023
Merged

Remove confusing indirection. #49

merged 1 commit into from
Nov 11, 2023

Conversation

szmyd
Copy link
Collaborator

@szmyd szmyd commented Nov 11, 2023

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (d7e3366) 73.70% compared to head (d05d090) 75.73%.
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
+ Coverage   73.70%   75.73%   +2.03%     
==========================================
  Files          21       21              
  Lines         848      812      -36     
  Branches       96       95       -1     
==========================================
- Hits          625      615      -10     
+ Misses        164      134      -30     
- Partials       59       63       +4     
Files Coverage Δ
src/include/nuraft_mesg/mesg_factory.hpp 100.00% <100.00%> (ø)
src/include/nuraft_mesg/mesg_state_mgr.hpp 100.00% <ø> (ø)
src/include/nuraft_mesg/nuraft_mesg.hpp 100.00% <ø> (ø)
src/lib/factory.cpp 74.31% <ø> (ø)
src/lib/manager_impl.hpp 0.00% <ø> (-50.00%) ⬇️
src/lib/proto/proto_client.cpp 90.69% <ø> (ø)
src/lib/repl_service_ctx.hpp 100.00% <100.00%> (ø)
src/lib/service.hpp 0.00% <ø> (-25.00%) ⬇️
src/lib/proto/proto_service.cpp 71.23% <93.54%> (ø)
src/lib/repl_service_ctx.cpp 91.66% <91.66%> (ø)
... and 2 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@szmyd szmyd merged commit 80668a2 into eBay:main Nov 11, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants