Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded indirection in code path. #46

Closed
wants to merge 3 commits into from

Conversation

szmyd
Copy link
Collaborator

@szmyd szmyd commented Nov 10, 2023

No API changes.

This just removes some of the clutter left from merging nuraft_grpc with sds_messaging and prepares for easier optional FlatBuffers serialization code path (while retaining Protobuf).

I also improved the logging and fixed a couple race issues in the UTs.

@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2023

Codecov Report

Attention: 59 lines in your changes are missing coverage. Please review.

Comparison is base (8066124) 77.07% compared to head (ebd94dd) 74.51%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
- Coverage   77.07%   74.51%   -2.57%     
==========================================
  Files          20       19       -1     
  Lines         820      769      -51     
  Branches       91       90       -1     
==========================================
- Hits          632      573      -59     
- Misses        132      137       +5     
- Partials       56       59       +3     
Files Coverage Δ
src/lib/manager_impl.hpp 50.00% <ø> (ø)
src/lib/mesg_factory.cpp 90.00% <100.00%> (ø)
src/lib/grpc_factory.cpp 74.31% <0.00%> (ø)
src/lib/common_lib.hpp 0.00% <0.00%> (ø)
src/lib/manager_impl.cpp 72.78% <65.33%> (-7.13%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@szmyd szmyd marked this pull request as ready for review November 10, 2023 17:49
@szmyd szmyd requested review from raakella1 and hkadayam November 10, 2023 17:49
@szmyd szmyd linked an issue Nov 10, 2023 that may be closed by this pull request
@szmyd szmyd added this to the MileStone4.00 milestone Nov 10, 2023
@szmyd szmyd self-assigned this Nov 10, 2023
@szmyd szmyd added the enhancement New feature or request label Nov 10, 2023
@szmyd szmyd changed the title Merge service Remove unneeded indirection in code path. Nov 10, 2023
@szmyd szmyd removed the enhancement New feature or request label Nov 10, 2023
@szmyd szmyd marked this pull request as draft November 10, 2023 20:22
@szmyd szmyd closed this Nov 10, 2023
@szmyd szmyd deleted the merge_service branch November 10, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flatbuffers serialization for Raft Messages
2 participants