Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for FlatBuffers support #45

Merged
merged 4 commits into from
Nov 11, 2023
Merged

Prepare for FlatBuffers support #45

merged 4 commits into from
Nov 11, 2023

Conversation

szmyd
Copy link
Collaborator

@szmyd szmyd commented Nov 8, 2023

No description provided.

@szmyd szmyd linked an issue Nov 8, 2023 that may be closed by this pull request
@szmyd szmyd requested review from hkadayam and raakella1 November 8, 2023 18:54
@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2023

Codecov Report

Attention: 41 lines in your changes are missing coverage. Please review.

Comparison is base (8066124) 77.07% compared to head (b8192e9) 73.34%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
- Coverage   77.07%   73.34%   -3.73%     
==========================================
  Files          20       20              
  Lines         820      848      +28     
  Branches       91       96       +5     
==========================================
- Hits          632      622      -10     
- Misses        132      167      +35     
- Partials       56       59       +3     
Files Coverage Δ
src/lib/client.hpp 80.00% <ø> (ø)
src/lib/data_service_grpc.cpp 39.39% <ø> (ø)
src/lib/manager_impl.cpp 79.91% <100.00%> (ø)
src/lib/manager_impl.hpp 50.00% <ø> (ø)
src/lib/proto/proto_client.cpp 90.69% <100.00%> (ø)
src/lib/proto/proto_grpc_server.cpp 92.10% <ø> (ø)
src/lib/proto/proto_mesg_factory.cpp 90.90% <100.00%> (ø)
src/lib/proto/proto_service.cpp 67.32% <ø> (ø)
src/lib/service.hpp 25.00% <ø> (ø)
src/lib/common_lib.hpp 85.71% <85.71%> (ø)
... and 2 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@szmyd szmyd marked this pull request as ready for review November 10, 2023 21:30
@szmyd szmyd changed the title Initial FlatBuffers support Prepare for FlatBuffers support Nov 10, 2023
@szmyd szmyd merged commit 8d09e63 into eBay:main Nov 11, 2023
12 checks passed
@szmyd szmyd deleted the flatbuffers branch November 11, 2023 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flatbuffers serialization for Raft Messages
2 participants