Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging consistency #37

Merged
merged 4 commits into from
Oct 5, 2023
Merged

Logging consistency #37

merged 4 commits into from
Oct 5, 2023

Conversation

szmyd
Copy link
Collaborator

@szmyd szmyd commented Oct 5, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2023

Codecov Report

Attention: 58 lines in your changes are missing coverage. Please review.

Comparison is base (2d1bda7) 65.00% compared to head (62763c6) 65.62%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                    Coverage Diff                    @@
##           feature/folly_futures      #37      +/-   ##
=========================================================
+ Coverage                  65.00%   65.62%   +0.62%     
=========================================================
  Files                         20       20              
  Lines                        760      768       +8     
  Branches                      76       79       +3     
=========================================================
+ Hits                         494      504      +10     
+ Misses                       222      217       -5     
- Partials                      44       47       +3     
Files Coverage Δ
src/include/nuraft_mesg/mesg_factory.hpp 100.00% <100.00%> (ø)
src/lib/grpc_client.cpp 90.47% <100.00%> (ø)
src/lib/grpc_server.cpp 92.10% <ø> (ø)
src/lib/manager_impl.hpp 0.00% <ø> (ø)
src/lib/utils.hpp 30.43% <ø> (ø)
src/lib/grpc_client.hpp 80.00% <50.00%> (-5.72%) ⬇️
src/lib/service.hpp 25.00% <50.00%> (ø)
src/lib/data_service_grpc.cpp 0.00% <0.00%> (ø)
src/lib/manager_impl.cpp 71.71% <82.35%> (+3.42%) ⬆️
src/lib/mesg_client.cpp 60.49% <42.85%> (ø)
... and 3 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@szmyd szmyd merged commit 8fba3c6 into eBay:feature/folly_futures Oct 5, 2023
@szmyd szmyd deleted the semifutures branch October 5, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants