Simplify the raft_event callback for mesg_state_mgr. #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Existing implementation was clumsy and incorrect. Simplify.
szmyd
force-pushed
the
simplify_raft_event
branch
from
50750b2 to
a0aca42
Compare
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #112 +/- ##
==========================================
+ Coverage 71.47% 72.90% +1.42%
==========================================
Files 21 20 -1
Lines 887 882 -5
Branches 103 101 -2
==========================================
+ Hits 634 643 +9
+ Misses 188 171 -17
- Partials 65 68 +3 ☔ View full report in Codecov by Sentry. |
JacksonYao287
approved these changes
Dec 13, 2024
| if (auto sp = m_manager.lock(); sp) | ||
| sp->generic_raft_event_handler(group_id, type, param); | ||
| else | ||
| return nuraft::cb_func::ReturnNull; |
There was a problem hiding this comment.
NIT: pls add a log here(before line 394) to print out the ManagerImpl instance is destroyed(or shutdown), which will be helpful for debug
xiaoxichen
approved these changes
Dec 13, 2024
xiaoxichen
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existing implementation was clumsy and incorrect. Simplify.