Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix get peer info #107

Merged
merged 3 commits into from
Nov 18, 2024
Merged

fix get peer info #107

merged 3 commits into from
Nov 18, 2024

Conversation

JacksonYao287
Copy link
Contributor

@JacksonYao287 JacksonYao287 commented Nov 15, 2024

1 fix a bug that a peer does not exist in the configuration of leader

for remove_member case , leader will first remove the member from peer_list, and then apply the new cluster configuraiton which excludes the removed member. if a leader get peer_list before the to-be-removed node is removed from the peer_list, and then try to get_srv_config after the node is removed for the cluster config (new config is applied), then it can not find this peer in the configuration.

2 support follower to get its own peer info , which is useful for upper layer to get the last append log index of a follower.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 61.53846% with 5 lines in your changes missing coverage. Please review.

Project coverage is 72.71%. Comparing base (0262682) to head (d43f11b).
Report is 43 commits behind head on main.

Files with missing lines Patch % Lines
src/lib/repl_service_ctx.cpp 61.53% 2 Missing and 3 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #107      +/-   ##
==========================================
+ Coverage   71.47%   72.71%   +1.24%     
==========================================
  Files          21       20       -1     
  Lines         887      876      -11     
  Branches      103       99       -4     
==========================================
+ Hits          634      637       +3     
+ Misses        188      172      -16     
- Partials       65       67       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@xiaoxichen xiaoxichen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JacksonYao287 JacksonYao287 merged commit ec3ca39 into eBay:main Nov 18, 2024
12 checks passed
@JacksonYao287 JacksonYao287 deleted the fix-get-peer-info branch November 18, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants