Allow alt text annotations to be deleted #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebnance
reviewed
Dec 18, 2024
src/data/routes-native.json
Outdated
| @@ -28,7 +28,7 @@ | |||
| "label": "Alternative text", | |||
| "designerCheck": "Alternative text", | |||
| "path": "alt-text", | |||
| "shouldHide": true, | |||
| "shouldHide": false, | |||
| "percent": 20 | |||
There was a problem hiding this comment.
@gert-janvercauteren what was the reason for this change? it's breaking the native flow for me
There was a problem hiding this comment.
This was not on purpose!
| @@ -292,6 +293,7 @@ export const add = (msg) => { | |||
| // update with id (for future scanning) | |||
| altTextFrame.name = `${altTextLayerName} | ${altTextFrame.id}`; | |||
| altTextFrame.expanded = false; | |||
| altTextFrame.locked = true; | |||
There was a problem hiding this comment.
@gert-janvercauteren nice add!
src/ui.js
Outdated
|
|
||
| // should hide flag is true and step data exists | ||
| if (shouldHide === true && stepsDataKeysArray.includes(key)) { | ||
| // if not current path, hide layer + force hide override | ||
| if (currentPath !== path || forceHide === true) { |
There was a problem hiding this comment.
@gert-janvercauteren all of this still needs to be there, this hides the annotation layer so that when users add images manually, they don't accidentally select the annotation layer(s) when trying to select layers from the design file
There was a problem hiding this comment.
With the locked alt text layer, you won't be able to select it.
I'll revert, as this is not the main aim for the changes :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
n/aand input field so the text is visually alignedChecklist: