#20 Enable Non String values in JsonFieldPatternBuilder #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prasanthkv
changed the title
...ns/src/main/java/com/ebay/ejmask/extenstion/builder/json/JsonBooleanFieldPatternBuilder.java
Show resolved
Hide resolved
sumanthreddybandi
previously approved these changes
Nov 19, 2024
prasanthkv
reviewed
Nov 19, 2024
ejmask-api/src/main/java/com/ebay/ejmask/api/PatternEntity.java
Outdated
Show resolved
Hide resolved
prasanthkv
reviewed
Nov 19, 2024
ejmask-api/src/main/java/com/ebay/ejmask/api/PatternEntity.java
Outdated
Show resolved
Hide resolved
prasanthkv
previously approved these changes
Nov 20, 2024
auto-merge was automatically disabled
November 20, 2024 05:28
Head branch was pushed to by a user without write access
chengjared
reviewed
Nov 20, 2024
ejmask-api/src/main/java/com/ebay/ejmask/api/IPatternBuilder.java
Outdated
Show resolved
Hide resolved
ejmask-api/src/main/java/com/ebay/ejmask/api/PatternEntity.java
Outdated
Show resolved
Hide resolved
...ns/src/main/java/com/ebay/ejmask/extenstion/builder/json/JsonBooleanFieldPatternBuilder.java
Outdated
Show resolved
Hide resolved
chengjared
reviewed
Nov 20, 2024
...rc/test/java/com/ebay/ejmask/extenstion/builder/json/JsonBooleanFieldPatternBuilderTest.java
Show resolved
Hide resolved
...rc/test/java/com/ebay/ejmask/extenstion/builder/json/JsonNumericFieldPatternBuilderTest.java
Show resolved
Hide resolved
prasanthkv
approved these changes
Nov 20, 2024
prasanthkv
reviewed
Nov 21, 2024
...xtensions/src/main/java/com/ebay/ejmask/extenstion/builder/json/JsonFieldPatternBuilder.java
Show resolved
Hide resolved
prasanthkv
reviewed
Nov 21, 2024
...ns/src/main/java/com/ebay/ejmask/extenstion/builder/json/JsonNumericFieldPatternBuilder.java
Outdated
Show resolved
Hide resolved
prasanthkv
previously approved these changes
Nov 21, 2024
RandySun228
force-pushed
the
master
branch
2 times, most recently
from
b969783 to
828f6b1
Compare
auto-merge was automatically disabled
November 25, 2024 04:43
Pull request was closed
RandySun228
requested review from
chengjared,
prasanthkv and
sumanthreddybandi
sumanthreddybandi
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR is to address issue: #17.
JsonFieldPatternBuilder does not support non string data mask, so create this PR to fix it. Numeric and boolean data are supported.
Proposed Changes
Test Plan
Test is covered by UT