Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Logging the stack trace for an exception is important because it helps in troubleshooting and debugging the root cause of the problem. It identifies the point where the error occurred, the method that threw the error, and the execution sequence that led to the error.
ex.getMessage()
will not have context in exceptions such asNullPointerException
andStackOverflowError
. These are exceptions with no messages.Proposed Changes
CommonUtils
namedgetStackTrace
that accepts aThrowable
and returns the stack trace. This method is invoked in all the places we want to log an exception.Test Plan
CommonUtils
testMask_fail_safe()
andgetStackTrace_whenExceptionThrown_shouldPrintStackTrace()
assert that when an exception occurs, stack trace is printed.mvn clean install
is success for all modules.Screenshots:
Difference between previous and current logging
Build success