Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(EbaySvg): Hide SVG definition from screen readers #379

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

HenriqueLimas
Copy link
Member

Currently screen readers are announcing the SVG icon definitions when hitting the page. This PR is to hide them from screen readers

@HenriqueLimas HenriqueLimas added the bug Something isn't working label Dec 12, 2024
@HenriqueLimas HenriqueLimas self-assigned this Dec 12, 2024
Copy link
Contributor

@shpandian shpandian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shpandian shpandian merged commit fdbc35a into main Dec 13, 2024
6 checks passed
@shpandian shpandian deleted the hlimas/a11y-svg branch December 13, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants