Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removes unnecessary 'role' in <section ...> elements #356

Closed
wants to merge 1 commit into from

Conversation

rglombov
Copy link
Contributor

@rglombov rglombov commented Aug 8, 2024

According to https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/region_role#prefer_html, it is not necessary to specify role to <section> elements.

@abiyasa
Copy link
Member

abiyasa commented Aug 12, 2024

As discussed on Slack with eBay Skin and accessibility team, we will keep both <section> and role-region even though it's redundant:

I am closing this ticket as won't fix/change.

@abiyasa abiyasa closed this Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants