-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Figma Code Connect #345
base: main
Are you sure you want to change the base?
Figma Code Connect #345
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR. In the @figma/code-connect
documentation, they suggest to use storybook instead. Isn't possible to use our stories instead?
@@ -62,6 +62,7 @@ | |||
"@babel/preset-typescript": "^7.23.3", | |||
"@babel/register": "^7.0.0", | |||
"@ebay/skin": "^17.0.0", | |||
"@figma/code-connect": "^0.1.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to also add a new script that we will need to use to make the connection
"scripts": {
...,
"figma:connect": "figma connect publish \"https://...\" --token $FIGMA_TOKEN"
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HenriqueLimas this has been added, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@calebnance did we also go through SAFE review? if so can you attach a SAFE ticket in the PR description as well? |
@HenriqueLimas |
hey @HenriqueLimas
i think Stephen has already talked to you about this coming down the pipeline. please add anyone else to this PR that might need to be on here.
this is the first go at it, but i have mapped most if not all components to our DS library on figma. i wanted to get this in front of y'all so we can talk around it, and let me know of any changes needed. you can test this right now on designs that use our ds components, just make sure you're in dev mode.
also the more i looked at it; there are definitely different namings + how DS has structured their components vs how the React components are structured, so i did the best i could where things are not 1:1.
example when in dev mode:
i have also hooked up variant handling where i could: