FIX: label text overlap for selected option (#261)

eBay · Oct 16, 2023 · 0f97830 · 0f97830
1 parent 328c5bb
commit 0f97830
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/src/ebay-listbox-button/__tests__/__snapshots__/index.spec.tsx.snap b/src/ebay-listbox-button/__tests__/__snapshots__/index.spec.tsx.snap
@@ -288,6 +288,11 @@ exports[`Storyshots ebay-listbox-button Floating label 1`] = `
       >
         Select
       </span>
+      <span
+        className="btn__text"
+      >
+        -
+      </span>
       <svg
         aria-hidden={true}
         className="icon icon--chevron-down-16"

diff --git a/src/ebay-listbox-button/listbox-button.tsx b/src/ebay-listbox-button/listbox-button.tsx
@@ -243,12 +243,10 @@ const ListboxButton: FC<EbayListboxButtonProps> = ({
     })
     const expandBtnTextId = prefixId && 'expand-btn-text'
 
-    const buttonLabel = floatingLabel ? (
-        <span className="btn__floating-label">
-            {floatingLabel}
-        </span>
-    ) : (
+
+    const buttonLabel = (
         <>
+            {floatingLabel && <span className="btn__floating-label">{floatingLabel}</span>}
             {prefixLabel && <span className="btn__label">{prefixLabel}</span>}
             <span className="btn__text" id={expandBtnTextId}>
                 {selectedOption?.props.children || unselectedText}
-Original file line number
+Diff line change
@@ Expand Up @@
           >
             Select
           </span>
+          <span
+            className="btn__text"
+          >
+            -
+          </span>
           <svg
             aria-hidden={true}
             className="icon icon--chevron-down-16"
@@ Expand Down @@