use ninja 1.12.1 to work around 1.11.1 issue #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scikit-build/ninja-python-distributions#157 12:18:50 pistache 0.0.5 12:18:50 12:18:50 User defined options 12:18:50 Native files: /home/jenkins/.conan2/p/b/pistad34507cfa27c1/b/build-debug/conan/conan_meson_native.ini 12:18:50 prefix : / 12:18:50 12:18:50 12:18:50 ERROR: Could not detect Ninja v1.8.2 or newer We hit above issue during rebuilding pistache for both 0.0.5 and 0.0.5.1. Searched around seems due to the python packaging has issues. Signed-off-by: Xiaoxi Chen <[email protected]>
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #103 +/- ##
==========================================
+ Coverage 45.26% 45.30% +0.04%
==========================================
Files 54 54
Lines 4012 4059 +47
Branches 478 484 +6
==========================================
+ Hits 1816 1839 +23
- Misses 2065 2088 +23
- Partials 131 132 +1 ☔ View full report in Codecov by Sentry. |
|
sample failure build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scikit-build/ninja-python-distributions#157
12:18:50 pistache 0.0.5
12:18:50
12:18:50 User defined options
12:18:50 Native files: /home/jenkins/.conan2/p/b/pistad34507cfa27c1/b/build-debug/conan/conan_meson_native.ini
12:18:50 prefix : /
12:18:50
12:18:50
12:18:50 ERROR: Could not detect Ninja v1.8.2 or newer
We hit above issue during rebuilding pistache for both 0.0.5 and 0.0.5.1. Searched around seems due to the python packaging has issues.