Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read_logical_snp_obj: pass user_ctx to prevent memleak #617

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

koujl
Copy link
Contributor

@koujl koujl commented Dec 20, 2024

Ensure user_ctx is passed up to NuRaft regardless of the return value to enable the cleanup of the allocated context object.

@koujl koujl requested a review from yuwmao December 20, 2024 07:35
Ensure user_ctx is passed up to NuRaft regardless of the return value to
enable the cleanup of the allocated context object.

Signed-off-by: Jilong Kou <[email protected]>
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.44%. Comparing base (1a0cef8) to head (a1d5170).
Report is 108 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #617      +/-   ##
==========================================
+ Coverage   56.51%   66.44%   +9.93%     
==========================================
  Files         108      109       +1     
  Lines       10300    10861     +561     
  Branches     1402     1483      +81     
==========================================
+ Hits         5821     7217    +1396     
+ Misses       3894     2936     -958     
- Partials      585      708     +123     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@yuwmao yuwmao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@koujl koujl merged commit 6695df2 into eBay:master Dec 20, 2024
21 checks passed
@koujl koujl deleted the user_ctx branch December 20, 2024 08:59
@koujl koujl restored the user_ctx branch December 23, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants