Refine variant_node::put return value #615
Conversation
Replace the generic put_failed error status with more specific error messages to enhance clarity and prevent confusion during log analysis.
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #615 +/- ##
==========================================
+ Coverage 56.51% 66.38% +9.86%
==========================================
Files 108 109 +1
Lines 10300 10843 +543
Branches 1402 1485 +83
==========================================
+ Hits 5821 7198 +1377
+ Misses 3894 2932 -962
- Partials 585 713 +128 ☔ View full report in Codecov by Sentry. |
| @@ -56,7 +56,7 @@ retry: | |||
| const auto matched = my_node->match_range(req.working_range(), start_idx, end_idx); | |||
| if (!matched) { | |||
| BT_NODE_LOG_ASSERT(false, my_node, "match_range returns 0 entries for interior node is not valid pattern"); | |||
| ret = btree_status_t::put_failed; | |||
| ret = btree_status_t::not_found; | |||
There was a problem hiding this comment.
@xiaoxichen It is unclear to me. It needs some explanation for the different cases. A caller wants to insert but get into a range that may be wrong, what does not_found mean? it is not supposed not to be found.
There was a problem hiding this comment.
What do you think? in which case we will hit into this?
Replace the generic put_failed error status with more specific error messages to enhance clarity and prevent confusion during log analysis.