Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lock for log dev read api's. #612

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

sanebay
Copy link
Contributor

@sanebay sanebay commented Dec 17, 2024

Avoid concurrent access to journal vdev for truncate, write and read api's from different threads.

Avoid concurrent access to journal vdev for truncate, write
and read api's from different threads.
@sanebay sanebay force-pushed the journal_vdev_read_lock branch from 543c5d0 to b2894a4 Compare December 17, 2024 20:15
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.38%. Comparing base (1a0cef8) to head (b2894a4).
Report is 104 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #612      +/-   ##
==========================================
+ Coverage   56.51%   66.38%   +9.86%     
==========================================
  Files         108      109       +1     
  Lines       10300    10840     +540     
  Branches     1402     1486      +84     
==========================================
+ Hits         5821     7196    +1375     
+ Misses       3894     2935     -959     
- Partials      585      709     +124     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@JacksonYao287 JacksonYao287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. let`s revisit here if any performance issue surfaces in performance test

@sanebay sanebay merged commit 707c111 into eBay:master Dec 18, 2024
21 checks passed
@sanebay sanebay deleted the journal_vdev_read_lock branch December 18, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants