Set min_log_gap_to_join to max_int32. #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #587 +/- ##
===========================================
+ Coverage 56.51% 67.23% +10.72%
===========================================
Files 108 109 +1
Lines 10300 10726 +426
Branches 1402 1465 +63
===========================================
+ Hits 5821 7212 +1391
+ Misses 3894 2819 -1075
- Partials 585 695 +110 ☔ View full report in Codecov by Sentry. |
|
looks good, can you also set |
Signed-off-by: Xiaoxi Chen <[email protected]>
JacksonYao287
approved these changes
Nov 13, 2024
| @@ -242,7 +242,7 @@ table Consensus { | |||
| stale_log_gap_lo_threshold: int32 = 30; | |||
|
|
|||
| // Minimum log gap a replica has to be from leader before joining the replica set. | |||
| min_log_gap_to_join: int32 = 30; | |||
| min_log_gap_to_join: int32 = 2147483647; | |||
There was a problem hiding this comment.
NIT : can we change 2147483647 to some kind like 0x7FFFFFFF or INT32_MAX , which will be more readable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.