Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change replace member api signature. #570

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

sanebay
Copy link
Contributor

@sanebay sanebay commented Oct 21, 2024

Changed the api signature because homeobject gets Member info with name, priority etc. But homestore api's dont have that.
Add replica member info with name, priority and id. Use replica member info for replace member api and listener callbacks.

@codecov-commenter
Copy link

codecov-commenter commented Oct 21, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 55.55556% with 12 lines in your changes missing coverage. Please review.

Project coverage is 66.89%. Comparing base (1a0cef8) to head (6954fdd).
Report is 79 commits behind head on master.

Files with missing lines Patch % Lines
src/lib/replication/repl_dev/raft_repl_dev.cpp 68.42% 6 Missing ⚠️
src/lib/replication/service/raft_repl_service.cpp 16.66% 5 Missing ⚠️
src/lib/replication/service/generic_repl_svc.cpp 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #570       +/-   ##
===========================================
+ Coverage   56.51%   66.89%   +10.38%     
===========================================
  Files         108      109        +1     
  Lines       10300    10586      +286     
  Branches     1402     1432       +30     
===========================================
+ Hits         5821     7082     +1261     
+ Misses       3894     2824     -1070     
- Partials      585      680       +95     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

xiaoxichen
xiaoxichen previously approved these changes Oct 22, 2024
Copy link
Collaborator

@xiaoxichen xiaoxichen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except suggesting bump conan version to 6.5.1 as this is a breaking api change

@sanebay sanebay force-pushed the replace_member_api branch 2 times, most recently from 26af47e to 5b96186 Compare October 22, 2024 21:57
Add replica member info with name, priority and id.
Use replica member info for replace member api and listener callbacks.
@sanebay sanebay force-pushed the replace_member_api branch from 5b96186 to 6954fdd Compare October 23, 2024 02:00
Copy link
Collaborator

@xiaoxichen xiaoxichen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@JacksonYao287 JacksonYao287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiaoxichen xiaoxichen merged commit a5b2969 into eBay:master Oct 23, 2024
21 checks passed
@sanebay sanebay deleted the replace_member_api branch October 23, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants