-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change replace member api signature. #570
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #570 +/- ##
===========================================
+ Coverage 56.51% 66.89% +10.38%
===========================================
Files 108 109 +1
Lines 10300 10586 +286
Branches 1402 1432 +30
===========================================
+ Hits 5821 7082 +1261
+ Misses 3894 2824 -1070
- Partials 585 680 +95 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except suggesting bump conan version to 6.5.1 as this is a breaking api change
26af47e
to
5b96186
Compare
Add replica member info with name, priority and id. Use replica member info for replace member api and listener callbacks.
5b96186
to
6954fdd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changed the api signature because homeobject gets Member info with name, priority etc. But homestore api's dont have that.
Add replica member info with name, priority and id. Use replica member info for replace member api and listener callbacks.