Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX wbcache for put and modify long running index #567

Merged

Conversation

shosseinimotlagh
Copy link
Contributor

No description provided.

@shosseinimotlagh shosseinimotlagh changed the title Fix crash simulation p2 FIX wbcache for put and modify long running index Oct 17, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 53.65854% with 38 lines in your changes missing coverage. Please review.

Project coverage is 66.97%. Comparing base (1a0cef8) to head (f273ee6).
Report is 76 commits behind head on master.

Files with missing lines Patch % Lines
src/lib/index/wb_cache.cpp 67.79% 15 Missing and 4 partials ⚠️
src/lib/index/index_cp.cpp 0.00% 12 Missing ⚠️
src/include/homestore/btree/detail/simple_node.hpp 0.00% 2 Missing ⚠️
src/include/homestore/index/index_table.hpp 0.00% 2 Missing ⚠️
src/lib/index/index_cp.hpp 0.00% 2 Missing ⚠️
...rc/include/homestore/btree/detail/btree_common.ipp 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #567       +/-   ##
===========================================
+ Coverage   56.51%   66.97%   +10.46%     
===========================================
  Files         108      109        +1     
  Lines       10300    10592      +292     
  Branches     1402     1431       +29     
===========================================
+ Hits         5821     7094     +1273     
+ Misses       3894     2813     -1081     
- Partials      585      685      +100     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/lib/index/wb_cache.hpp Outdated Show resolved Hide resolved
src/lib/index/wb_cache.cpp Show resolved Hide resolved
src/lib/index/wb_cache.cpp Outdated Show resolved Hide resolved
src/lib/index/wb_cache.cpp Outdated Show resolved Hide resolved
src/lib/index/wb_cache.cpp Outdated Show resolved Hide resolved
src/lib/index/wb_cache.cpp Outdated Show resolved Hide resolved
@shosseinimotlagh shosseinimotlagh force-pushed the fix-crash-simulation-p2 branch 2 times, most recently from 10d4693 to c31f442 Compare October 18, 2024 18:12
Copy link
Contributor

@koujl koujl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shosseinimotlagh shosseinimotlagh merged commit b182e7f into eBay:master Oct 22, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants