-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix long duration of write_to_full test case and max_io test case #533
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #533 +/- ##
===========================================
+ Coverage 56.51% 67.89% +11.38%
===========================================
Files 108 109 +1
Lines 10300 10435 +135
Branches 1402 1400 -2
===========================================
+ Hits 5821 7085 +1264
+ Misses 3894 2681 -1213
- Partials 585 669 +84 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
ee71ec6
return empty string upon failed client lookup
before install snapshot completes, raft_server()->get_committed_log_idx() will be the same if write_snapshot_data is called several times, so that snp_data->offset can not be updated to new cursor. this PR use a separate last_data_committed_lsn to maintain the last committed lsn for writing data, which is use for updating snp_data->offset in write_snapshot_data
* horten log store test * remove android in Setup Conan phrase
Testing: