Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start rreq timer after it is linked in state machine #507

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

raakella1
Copy link
Contributor

No description provided.

@raakella1 raakella1 requested a review from xiaoxichen August 16, 2024 16:37
Copy link
Collaborator

@xiaoxichen xiaoxichen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 56.46%. Comparing base (1a0cef8) to head (8acd1e5).
Report is 43 commits behind head on master.

Files Patch % Lines
src/include/homestore/replication/repl_dev.h 0.00% 2 Missing ⚠️
...rc/lib/replication/repl_dev/raft_state_machine.cpp 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #507      +/-   ##
==========================================
- Coverage   56.51%   56.46%   -0.05%     
==========================================
  Files         108      109       +1     
  Lines       10300    10521     +221     
  Branches     1402     1429      +27     
==========================================
+ Hits         5821     5941     +120     
- Misses       3894     3973      +79     
- Partials      585      607      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@raakella1 raakella1 merged commit fe44e3b into eBay:master Aug 16, 2024
21 checks passed
@raakella1 raakella1 deleted the reset_rreq_timer branch August 16, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants