Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert log store lsn to repl lsn in repl_dev #505

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

raakella1
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 56.53%. Comparing base (1a0cef8) to head (da8e8df).
Report is 42 commits behind head on master.

Files Patch % Lines
src/lib/replication/repl_dev/raft_repl_dev.cpp 0.00% 13 Missing ⚠️
...rc/lib/replication/repl_dev/raft_state_machine.cpp 0.00% 2 Missing ⚠️
src/lib/replication/repl_dev/common.cpp 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #505      +/-   ##
==========================================
+ Coverage   56.51%   56.53%   +0.02%     
==========================================
  Files         108      109       +1     
  Lines       10300    10520     +220     
  Branches     1402     1428      +26     
==========================================
+ Hits         5821     5948     +127     
- Misses       3894     3967      +73     
- Partials      585      605      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@JacksonYao287 JacksonYao287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JacksonYao287 JacksonYao287 merged commit 1e1e868 into eBay:master Aug 16, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants