Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make leader to delete the raft repl dev in UT. #500

Closed
wants to merge 1 commit into from

Conversation

sanebay
Copy link
Contributor

@sanebay sanebay commented Aug 14, 2024

UT hangs as deletion repl dev causes follower not find to the leader, Keep the leader up till all the followers leave. There is still some issue with nuraft_mesg with client not connecting sometimes. This needs to be debugged separately.

@sanebay sanebay requested review from yamingk and xiaoxichen August 14, 2024 23:58
@sanebay sanebay force-pushed the test_raft_repl_issue branch from b973722 to 567491d Compare August 15, 2024 00:00
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 56.59%. Comparing base (1a0cef8) to head (567491d).
Report is 40 commits behind head on master.

Files Patch % Lines
src/lib/replication/repl_dev/raft_repl_dev.cpp 0.00% 3 Missing ⚠️
src/lib/replication/service/raft_repl_service.cpp 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #500      +/-   ##
==========================================
+ Coverage   56.51%   56.59%   +0.07%     
==========================================
  Files         108      109       +1     
  Lines       10300    10517     +217     
  Branches     1402     1432      +30     
==========================================
+ Hits         5821     5952     +131     
- Misses       3894     3959      +65     
- Partials      585      606      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sanebay sanebay linked an issue Aug 16, 2024 that may be closed by this pull request
@sanebay sanebay closed this Sep 11, 2024
@sanebay sanebay deleted the test_raft_repl_issue branch September 11, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Raft repl dev UT hangs during RemoveRaftReplDev
2 participants