waiting until all the callbacks are done before stopping #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JacksonYao287
commented
Aug 14, 2024
| @@ -500,8 +500,12 @@ class SampleDB { | |||
| } | |||
|
|
|||
| void on_log_insert_completion(logdev_id_t fid, logstore_seq_num_t lsn, logdev_key ld_key) { | |||
| if (m_highest_log_idx.count(fid) == 0) { m_highest_log_idx[fid] = std::atomic{-1}; } | |||
| atomic_update_max(m_highest_log_idx[fid], ld_key.idx); | |||
| { | |||
There was a problem hiding this comment.
many on_log_insert_completion might be executed in different reactors (threads). theoretically, different threads might modify and access m_highest_log_idx concurrently , which might cause a segfault . so add a lock here
There was a problem hiding this comment.
do we want to add lock also to
HomeStore/src/tests/test_log_store.cpp
Line 521 in 2080ad4
xiaoxichen
previously approved these changes
Aug 14, 2024
xiaoxichen
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before stopping logdev, we should wait until all the callbacks are done to avoid memroy leak